Track Previously Seen Merkle Index to Prevent Duplicate Log Spam #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into fix-encoding-decoding
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
=========================================
- Coverage 71.98% 71.39% -0.6%
=========================================
Files 99 99
Lines 6732 6568 -164
=========================================
- Hits 4846 4689 -157
+ Misses 1471 1466 -5
+ Partials 415 413 -2 |
rauljordan
requested review from
nisdas,
prestonvanloon and
terencechain
and removed request for
nisdas and
prestonvanloon
terencechain
approved these changes
Feb 12, 2019
| BeaconDB: &db.BeaconDB{}, | ||
| }) | ||
| if err != nil { | ||
| t.Fatalf("unable to setup web3 ETH1.0 chain service: %v", err) |
prestonvanloon
approved these changes
Feb 12, 2019
beacon-chain/powchain/service.go
Outdated
| // ETH1.0 network, and prevents us from updating our trie | ||
| // with the same log twice, causing an inconsistent state root. | ||
| index := binary.LittleEndian.Uint64(merkleTreeIndex) | ||
| if int64(index) == w.lastReceivedMerkleIndex { |
There was a problem hiding this comment.
Shouldn't it be
if int64(index) <= w.lastReceivedMerkleIndex {
?
added 2 commits
February 12, 2019 13:39
…o track-prev-index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1565
Description
Write why you are making the changes in this pull request
Sometimes we might receive duplicate logs from the ETH1.0 nodes we are connected to, causing our powchain service to unnecessarily update its deposit trie with this log even though we have already seen this Merkle index. This is a bug as it leaves our trie with an inconsistent root.
Write a summary of the changes you are making
This PR introduces a variable called
lastReceivedMerkleIndexin our powchain service which we use to check if we have already seen a Merkle index, preventing unnecessary updates to the trie. This PR adds a test for this duplicate log spam to check the root does not change.