Fixed Epoch Committee Count's Lower Bound to 1 #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
==========================================
- Coverage 71.73% 71.49% -0.25%
==========================================
Files 93 93
Lines 6507 6440 -67
==========================================
- Hits 4668 4604 -64
Misses 1432 1432
+ Partials 407 404 -3 |
|
|
||
| // Max committee count per slot will be 0 when shard count is less than epoch length, this | ||
| // covers the special case to ensure there's always 1 max committee count per slot. | ||
| var maxCommitteePerSlot = uint64(1) |
There was a problem hiding this comment.
It would make more sense to set this to the minimum.
var maxCommitteePerSlot = minCommitteePerSlot
prestonvanloon
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1565
This fixes a special case when the shard count is less than epoch length which results epoch committee count to be 0. This is special case covered in spec since they are fixed at 1024 and 64.