Pending Attestations RPC Server/Client Implementation #1617
+469
−121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1565 and a follow-up to #1606
Description
Write why you are making the changes in this pull request
In #1606, a method of obtaining pending attestations up to MAX_ATTESTATIONS from the operations service was implemented. This allows us to implement an RPC method in our server/client which can allow proposers to retrieve these pending attestations when performing their proposal responsibility.
Write a summary of the changes you are making
This PR implements a simple RPC server method called
PendingAttestations
, which returns a list of*pb.Attestation
for a proposer to include in a beacon block. It also implements the call in theProposerBlock
method invalidator/client/validator_propose.go
. This PR adds relevant tests to ensure the behavior works as expected.Link anything that would be helpful or relevant to the reviewers
Diff is large due to gomock.