Align Epoch Processing With Spec #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
======================================
Coverage 73.2% 73.2%
======================================
Files 100 100
Lines 7258 7258
======================================
Hits 5313 5313
Misses 1484 1484
Partials 461 461 |
prestonvanloon
approved these changes
Feb 25, 2019
| continue | ||
| } | ||
| _, voteHeight, err := bs.powChainService.BlockExists(voteHash) | ||
| if err != nil { | ||
| log.Errorf("Could not fetch block height: %v", err) | ||
| log.Debugf("Could not fetch block height: %v", err) |
rauljordan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1565
Description
Write why you are making the changes in this pull request
In epoch processing, when fetching epoch boundary attestations, we were using the JustifiedBlockRootHash32 field of the attestation instead of EpochBoundaryRootHash32, leading current epoch boundary attestations to be nil.
Additionally, our epoch processing was not aligned with the current spec. Finality/justification was completely outdated and not updating correctly. This PR updates all epoch processing details to match v0.3.
There were also some underflow issues. When calculating the previous epoch, always use the helpers.PrevEpoch function instead of helpers.CurrentEpoch() - 1 to prevent underflow.