Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Change Check Fix #1713

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Registry Change Check Fix #1713

merged 3 commits into from
Feb 26, 2019

Conversation

rauljordan
Copy link
Contributor

Part of #1565


Description

This fixes the condition that checks if a registry change occurred from

if beaconState.ValidatorRegistryUpdateEpoch == helpers.SlotToEpoch(req.Slot)

to

if beaconState.ValidatorRegistryUpdateEpoch == helpers.SlotToEpoch(req.Slot)-1

@rauljordan rauljordan added the Bug Something isn't working label Feb 26, 2019
@rauljordan rauljordan added this to the Sapphire milestone Feb 26, 2019
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we wait on the merge? I want to think this through

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #1713 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files         101      101           
  Lines        7116     7116           
=======================================
  Hits         5130     5130           
  Misses       1522     1522           
  Partials      464      464

@terencechain terencechain merged commit f5178ef into master Feb 26, 2019
@rauljordan rauljordan deleted the fixregchange branch February 26, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants