Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Skipped Slots in Sync #1939

Merged
merged 6 commits into from
Mar 8, 2019
Merged

Handle Skipped Slots in Sync #1939

merged 6 commits into from
Mar 8, 2019

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Mar 8, 2019

Description

Write why you are making the changes in this pull request.

This PR is to allow us to handle skipped slots in initial sync.

Write a summary of the changes you are making.

  • Handle skipped slots by checking that their parent exists.
  • Add in regression test

@nisdas nisdas added Bug Something isn't working Ready For Review A pull request ready for code review labels Mar 8, 2019
@nisdas nisdas self-assigned this Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #1939 into master will decrease coverage by 0.24%.
The diff coverage is 54.16%.

@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
- Coverage   72.08%   71.84%   -0.25%     
==========================================
  Files         106      106              
  Lines        8038     7916     -122     
==========================================
- Hits         5794     5687     -107     
+ Misses       1720     1711       -9     
+ Partials      524      518       -6

beacon-chain/sync/initial-sync/service.go Outdated Show resolved Hide resolved
beacon-chain/sync/initial-sync/service.go Outdated Show resolved Hide resolved
beacon-chain/sync/initial-sync/service_test.go Outdated Show resolved Hide resolved
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rauljordan rauljordan merged commit 7c5a7fb into master Mar 8, 2019
@rauljordan rauljordan deleted the skippedSlots branch March 8, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants