Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p vendor code #221

Closed
wants to merge 1 commit into from
Closed

p2p vendor code #221

wants to merge 1 commit into from

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Jun 30, 2018

Do NOT merge without #222.

The idea here is that we review #222 then merge it into this branch. Then we merge this branch into master.

This code doesn't need much review besides https://github.com/prysmaticlabs/geth-sharding/blob/p2p-vendor/vendor/vendor.json

@prestonvanloon prestonvanloon self-assigned this Jun 30, 2018
@prestonvanloon prestonvanloon added this to the Ruby milestone Jun 30, 2018
@prestonvanloon
Copy link
Member Author

Travis failing because

fatal: No url found for submodule path 'vendor/github.com/libp2p/go-floodsub' in .gitmodules
The command "eval git submodule update --init --recursive " failed. Retrying, 2 of 3.
fatal: No url found for submodule path 'vendor/github.com/libp2p/go-floodsub' in .gitmodules
The command "eval git submodule update --init --recursive " failed. Retrying, 3 of 3.
fatal: No url found for submodule path 'vendor/github.com/libp2p/go-floodsub' in .gitmodules
The command "eval git submodule update --init --recursive " failed 3 times.
The command "git submodule update --init --recursive" failed and exited with 128 during .

I wonder if this is due to me trying to use the (unmerged) gossipsub branch.
If that is the case, we may be blocked until libp2p/go-libp2p-pubsub#67 is merged

@prestonvanloon
Copy link
Member Author

This is no longer needed with bazel

@prestonvanloon prestonvanloon deleted the p2p-vendor branch July 18, 2018 20:38
Redidacove pushed a commit to Redidacove/prysm that referenced this pull request Aug 13, 2024
…ticlabs#221)

* Add Update 4 of Jihoon Song

* Add Update 5 of Jihoon Song

* Add project proposal of Jihoon Song

* Link project proposal of Jihoon Song

---------

Co-authored-by: Mário Havel <61149543+taxmeifyoucan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant