Spec freeze updates #2312

prestonvanloon · 2019-04-20T16:20:53Z

Resolves #2307

Merge all v0.6+ features into this branch. This can be reviewed and merged when all boxes of #2307 are checked.

List your blockers here:

Remove spec test yaml from repo, use starlark & bazel to fetch from remote repository. Owner=preston
All spec tests passing Write Test Runners for Spec Tests in Their Respective Packages #2812
SSZ compliance Conformity Tests for v0.8 of the Specification go-ssz#41

codecov · 2019-04-20T16:21:43Z

Codecov Report

Merging #2312 into master will decrease coverage by 36.92%.
The diff coverage is 22.53%.

@@             Coverage Diff             @@
##           master    #2312       +/-   ##
===========================================
- Coverage   62.88%   25.95%   -36.93%     
===========================================
  Files         125       88       -37     
  Lines        9731     6889     -2842     
===========================================
- Hits         6119     1788     -4331     
- Misses       2885     4773     +1888     
+ Partials      727      328      -399

* add new package * fix all tests * lint

* Remove deprecated validator protos * Fix to comments

* benchmark process epoch * revert prof.out * Add some optimizations * beware where we use ActiveValidatorIndices... * revert extra file * gaz * quick commit to get feedback * revert extra file * started fixing tests * fixed broken TestProcessCrosslink_NoUpdate * gaz * cache randao seed * fixed all the tests * fmt and lint * spacing * Added todo * lint * revert binary file * started regression test * basic tests done * using a fifo for active indices cache * using a fifo for active count cache * using a fifo for total balance cache * using a fifo for active balance cache * using a fifo for start shard cache * using a fifo for seed cache * gaz * clean up * fixing tests * fixed all the core tests * fixed all the tests!!! * lint * comment * rm'ed commented code * cache size to 1000 should be good enough * optimized base reward * revert binary file * Added comments to calculate adjusted quotient outside

* add RequestBlock * run mockgen * implemented RequestBlock * updated proto definitions * updated tests * updated validator attest tests * done * comment * todo issue * removed unused proto

* sort participants slice * add bitfield functions and tests * added BitfieldBit test * add AttestationParticipantsNew * revert AttestationParticipants to its previous change * add tests * remove verifybitfieldnew * fix tests and remove multiple tests * remove duplicate test * change magic number into ceildiv8

* sort participants slice * add bitfield functions and tests * added BitfieldBit test * add AttestationParticipantsNew * revert AttestationParticipants to its previous change * add tests * remove verifybitfieldnew * fix tests and remove multiple tests * remove duplicate test * start work * convert attestation to indexed attestations * fix test for convert index * remove calling getter * add more tests * remove underscore

* update registry updates func * added tests and moved to epoch processing * fixed naming issues

* fix historical lenght * fix genesis state initialization and test * fix genesis state initialization and test * fix genesis state initialization and test * fix genesis state initialization and test

* local changes * add val sig * attester fix * one more fix * fixed all tests * rem validator issue

* attester fix * one more fix * fixed all tests * Fix validator prev balances calculation * go fmt * 48 bytes

* fix sync issue * fix build * add regression test * add var for magic number

* Work in progress, eth1data works, deposits are included at the appropriate time, and activation happens at the correct time * revert blockInfo being public * git tests to build, not yet pass though * add tests * some commentary * fix comment * goimports * fmt and remove unused method

* update rules_go * Fix some cross compile builds stuff * add missing deps * update to 0.19.1

* add beacon block and attestation files * add all types * include all new proto type definitions * add add all proto definitions * fix all comments to say 48 bytes * include latest changes * readd common * no swag * add build file * deps issue * right package names * address feedback, maintain parity between upstream ethereumapis * delete pb * bad gens

Resolves invalid url link to golangci-lint.

…v0.6

prestonvanloon

LGTM!

Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>

rauljordan · 2019-07-12T22:55:01Z

beacon-chain/attestation/service.go

 		// we only set the limit at 70% of the calculated amount to be safe so that relevant attestations
 		// arent carried over to the next batch.
-		a.poolLimit = attPerSlot * 7 / 10
+		a.poolLimit = int(attPerSlot) * 7 / 10


We should open a tracking issue to change this - to aggregate the attestations instead. These are magic numbers at the moment.

rauljordan · 2019-07-19T23:53:36Z

beacon-chain/blockchain/block_processing_test.go

@@ -27,8 +29,15 @@ import (
 // Ensure ChainService implements interfaces.
 var _ = BlockProcessor(&ChainService{})

+func init() {
+	// TODO(2993): remove this after ssz is optimized for mainnet.


This should be of form #2993, i wonder how the TODO linter didn't catch this - it's a minor detail anyways

either format is OK

rauljordan · 2019-07-19T23:56:08Z

beacon-chain/db/pending_deposits.go

@@ -77,12 +108,23 @@ func (db *BeaconDB) RemovePendingDeposit(ctx context.Context, d *pb.Deposit) {
 		return
 	}

+	depRoot, err := hashutil.HashProto(d)


We should not be using hash proto here

rauljordan · 2019-07-19T23:58:16Z

shared/featureconfig/flags.go

@@ -60,11 +60,12 @@ var ValidatorFlags = []cli.Flag{

 // BeaconChainFlags contains a list of all the feature flags that apply to the beacon-chain client.
 var BeaconChainFlags = []cli.Flag{
-	EnableComputeStateRootFlag,
 	EnableCrosslinksFlag,
 	EnableCheckBlockStateRootFlag,


Can this be removed?

rauljordan · 2019-07-19T23:58:31Z

shared/featureconfig/flags.go

@@ -60,11 +60,12 @@ var ValidatorFlags = []cli.Flag{

 // BeaconChainFlags contains a list of all the feature flags that apply to the beacon-chain client.
 var BeaconChainFlags = []cli.Flag{
-	EnableComputeStateRootFlag,
 	EnableCrosslinksFlag,


We should also remove this - we absolutely need crosslinks now

prestonvanloon mentioned this pull request Apr 23, 2019

Set genesis and epoch to 0 #2335

Closed

prestonvanloon added the In Progress label Apr 25, 2019

prestonvanloon marked this pull request as ready for review April 25, 2019 16:51

rauljordan mentioned this pull request May 14, 2019

Update Proposer/Attester Slashings and Slashing Helpers #2603

Merged

terencechain and others added 10 commits May 30, 2019 23:46

Optimize Shuffled Indices Cache (#2728)

5b46517

Refactor Deposit Contract Test Setup (#2731)

988b1fb

* add new package * fix all tests * lint

change hash function (#2732)

085962a

Remove Deprecated Validator Protobuf (#2727)

2fb1f3d

* Remove deprecated validator protos * Fix to comments

Fix most of skipped tests (#2735)

901966c

Cache Active Validator Indices, Count, and Balances (#2737)

5a04d0d

removed deprecated configs (#2755)

f4ebbff

Optimize Process Eth1 Data Vote (#2754)

60aba6c

Cleanup and Docs update (#2756)

ed2fadc

prestonvanloon mentioned this pull request Jun 5, 2019

Bitfield points to an invalid index in the committee #2600

Closed

Ivan Martinez and others added 5 commits June 6, 2019 07:22

Add graffiti and update generate seed (#2759)

ebc0d67

Benchmark Process Block with Attestations (#2758)

71eea35

Tidying up Godoc for Core Package (#2762)

5f1ec70

Clean up Old RPC Endpoints (#2763)

7d1b304

Update RPC end point for Proposer (#2767)

508c36a

* add RequestBlock * run mockgen * implemented RequestBlock * updated proto definitions * updated tests * updated validator attest tests * done * comment * todo issue * removed unused proto

prestonvanloon force-pushed the spec-v0.6 branch from b139afc to 508c36a Compare June 9, 2019 07:05

shayzluf and others added 8 commits June 9, 2019 16:28

Implement Justification and finalization Processing (#2448)

d77c3e2

changes name to signature (#2535)

1c0aa94

update registry updates func (#2521)

6a26fb2

* update registry updates func * added tests and moved to epoch processing * fixed naming issues

Update Committee Helpers to v0.6.0 (#2398)

cb63eca

Update Committee Helper Part 2 (#2592)

67902e1

Implement Process Slashings for 0.6 (#2523)

57bc107

Set ejection balance to 1.6 (#2987)

8114be7

terencechain mentioned this pull request Jul 18, 2019

[Tracking] Improve logging infrastructure #2991

Closed

prestonvanloon and others added 11 commits July 18, 2019 11:11

improve block processing log (#2990)

44a96ac

Fix HistoricalRootsLimit (#2989)

8b4996e

* fix historical lenght * fix genesis state initialization and test * fix genesis state initialization and test * fix genesis state initialization and test * fix genesis state initialization and test

hack config until #2993

6cde854

More Runtime Fixes (#2986)

f4c8e2b

* local changes * add val sig * attester fix * one more fix * fixed all tests * rem validator issue

fix finality issue (#2994)

e02e030

Fix validator prev balance calculation (#2992)

6cf11dc

* attester fix * one more fix * fixed all tests * Fix validator prev balances calculation * go fmt * 48 bytes

Fix Querier to handle Deposit Logs Race (#2999)

6ac15bf

* fix sync issue * fix build * add regression test * add var for magic number

Update rules go (#2975)

659dc6b

* update rules_go * Fix some cross compile builds stuff * add missing deps * update to 0.19.1

Update "Testing Prysm" readme section (#3000)

47b6b37

Resolves invalid url link to golangci-lint.

prestonvanloon removed the Blocked Blocked by research or external factors label Jul 19, 2019

prestonvanloon requested review from nisdas, rauljordan, terencechain, 0xKiwi and shayzluf July 19, 2019 22:00

terencechain and others added 4 commits July 19, 2019 15:12

Update badge to version 0.8.1

1c455c3

elaborate on test skip

39f4e8b

Merge branch 'spec-v0.6' of github.com:prysmaticlabs/prysm into spec-…

0b65b92

…v0.6

revert shared/p2p/options.go

933783a

prestonvanloon commented Jul 19, 2019

View reviewed changes

prestonvanloon and others added 2 commits July 19, 2019 18:51

make travis happy with goimports

e7b19e1

Update beacon-chain/core/blocks/block.go

72354f8

Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>

rauljordan approved these changes Jul 20, 2019

View reviewed changes

rauljordan merged commit e744d1a into master Jul 20, 2019

prestonvanloon mentioned this pull request Jul 21, 2019

Proposer compute state root fails #1977

Closed

0xKiwi deleted the spec-v0.6 branch April 17, 2020 17:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spec freeze updates #2312

Spec freeze updates #2312

prestonvanloon commented Apr 20, 2019 •

edited by rauljordan

Loading

codecov bot commented Apr 20, 2019 •

edited

Loading

prestonvanloon left a comment

rauljordan Jul 12, 2019

rauljordan Jul 19, 2019

prestonvanloon Jul 20, 2019

rauljordan Jul 19, 2019

rauljordan Jul 19, 2019

rauljordan Jul 19, 2019

Spec freeze updates #2312

Spec freeze updates #2312

Conversation

prestonvanloon commented Apr 20, 2019 • edited by rauljordan Loading

codecov bot commented Apr 20, 2019 • edited Loading

Codecov Report

prestonvanloon left a comment

Choose a reason for hiding this comment

rauljordan Jul 12, 2019

Choose a reason for hiding this comment

rauljordan Jul 19, 2019

Choose a reason for hiding this comment

prestonvanloon Jul 20, 2019

Choose a reason for hiding this comment

rauljordan Jul 19, 2019

Choose a reason for hiding this comment

rauljordan Jul 19, 2019

Choose a reason for hiding this comment

rauljordan Jul 19, 2019

Choose a reason for hiding this comment

prestonvanloon commented Apr 20, 2019 •

edited by rauljordan

Loading

codecov bot commented Apr 20, 2019 •

edited

Loading