Update Eth1data Protobuf Fields #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## spec-v0.6 #2315 +/- ##
=============================================
- Coverage 71.54% 68.86% -2.69%
=============================================
Files 117 117
Lines 9180 9178 -2
=============================================
- Hits 6568 6320 -248
- Misses 1932 2180 +248
+ Partials 680 678 -2 |
75 tasks
proto/beacon/p2p/v1/types.proto
Outdated
| // Total number of deposits | ||
| uint64 deposit_count = 2; | ||
| // Block hash | ||
| bytes block_hash32 = 3; |
prestonvanloon
requested changes
Apr 21, 2019
proto/beacon/p2p/v1/types.proto
Outdated
| @@ -190,8 +190,12 @@ message VoluntaryExit { | |||
| } | |||
|
|
|||
| message Eth1Data { | |||
| // Root of the deposit tree | |||
| bytes deposit_root_hash32 = 1; | |||
There was a problem hiding this comment.
Deposit root, drop the hash32
prestonvanloon
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2307
Updated Eth1data fields for Protobuf