Update Block Operations Proto Fields #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add nogo and fix lint issues * Run gazelle * better gazelle * ignore external struct tags
* fix * fix tests
* add feature flag to enable gossip sub in p2p * invert the enable/disable logic * add the flag in k8s and fix tests * gazellle * return empty config if nil
* do not cancel assignments goroutines * exclude rule * disable lostcancel for now
* pending atts * use proposal slot * attestation inclusion fix * lint * advance state transitions * gazelle * lint tests pass
* no registry update if block is nil * regression test * lint
* ensure block failed processing returns an error * fixed test * test assertion corrected * comments * fix tests * imports
* do not cancel assignments goroutines * exclude rule * disable lostcancel for now
…aticlabs/prysm into update-historicalBatch-and-deposit
…istoricalBatch-and-deposit
…e-historicalBatch-and-deposit
Codecov Report
@@ Coverage Diff @@
## spec-v0.6 #2338 +/- ##
=============================================
- Coverage 68.53% 68.38% -0.15%
=============================================
Files 117 117
Lines 9248 9234 -14
=============================================
- Hits 6338 6315 -23
- Misses 2238 2243 +5
- Partials 672 676 +4 |
0xKiwi
approved these changes
Apr 22, 2019
75 tasks
prestonvanloon
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2307
This PR updates block operations related proto fields