Update balance helpers v0.6 #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated base to spec-v0.6 |
shayzluf
requested review from
terencechain and
rauljordan
and removed request for
terencechain
|
Please fix build issues |
75 tasks
shayzluf
force-pushed
the
update-balance-helpers-v0.6
branch
from
748d4eb to
2e4a6a2
Compare
Codecov Report
@@ Coverage Diff @@
## spec-v0.6 #2348 +/- ##
=============================================
+ Coverage 68.29% 68.42% +0.13%
=============================================
Files 119 119
Lines 9260 9276 +16
=============================================
+ Hits 6324 6347 +23
+ Misses 2252 2247 -5
+ Partials 684 682 -2 |
terencechain
requested changes
Apr 24, 2019
shayzluf
force-pushed
the
update-balance-helpers-v0.6
branch
from
8bafabf to
89de4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Part of] #2307
Add helper functions to balance change
includes:
get_balance
set_balance
increase_balance
decrease_balance
Write why you are making the changes in this pull request
to comply with 0.6 spec
Write a summary of the changes you are making
changes in:
Link anything that would be helpful or relevant to the reviewers
https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#get_balance