Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Committee Helpers #2354

Closed
wants to merge 2 commits into from
Closed

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Apr 23, 2019

Part of #2307

This PR is temporally blocked by #2350. To wrap up compute_committee I'll need get_permuted_index

What changes in this PR:

  • Update get_epoch_committee_count
  • Update get_shard_delta
  • Update compute_committee
  • Update get_crosslink_committees_at_slot

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #2354 into spec-v0.6 will decrease coverage by 0.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           spec-v0.6    #2354      +/-   ##
=============================================
- Coverage      68.36%   68.35%   -0.02%     
=============================================
  Files            117      117              
  Lines           9234     9236       +2     
=============================================
  Hits            6313     6313              
- Misses          2244     2245       +1     
- Partials         677      678       +1

@shayzluf
Copy link
Contributor

shayzluf commented Apr 24, 2019

@terencechain I am working on permutatedIndex needed for compute_committee working on making the shuffle yaml to work. will push it when it parse and we will test it when you are done?

added t.Skip() with TODO to TestFromYaml_Pass
after completing compute committee

@terencechain
Copy link
Member Author

terencechain commented Apr 24, 2019

@terencechain I am working on permutatedIndex needed for compute_committee working on making the shuffle yaml to work. will push it when it parse and we will test it when you are done?

added t.Skip() with TODO to TestFromYaml_Pass
after completing compute committee

Not sure if I follow, Im working on compute_committee in this PR which needs permutatedIndex. #2350 is blocking this PR right now. You can skip TestFromYaml_Pass but add a todo there.

@terencechain
Copy link
Member Author

Thanks @0xKiwi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants