Implement new initiate validator exit function #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## spec-v0.6 #2366 +/- ##
==========================================
Coverage 68.71% 68.71%
==========================================
Files 119 119
Lines 9413 9413
==========================================
Hits 6468 6468
Misses 2262 2262
Partials 683 683 |
terencechain
changed the title
75 tasks
| return state | ||
| } | ||
|
|
||
| // Aggregate all the exit epochs from the last. |
| } | ||
|
|
||
| // Aggregate all the exit epochs from the last. | ||
| var exitedEpochs []uint64 |
There was a problem hiding this comment.
It looks like you are looking only for the highest epoch, no need to store all of them in an array and iterate over them to find the highest epoch.
There was a problem hiding this comment.
great feedback, this simplified it by a lot
0xKiwi
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2307
Updated:
InitiateValidatorExitInitiateValidatorExit