Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generateseed to 0.6 spec #2371

Merged
merged 6 commits into from
Apr 29, 2019

Conversation

shayzluf
Copy link
Contributor

[Part of] #2307


Update generate seed helpers

includes:
GenerateSeed

Write why you are making the changes in this pull request
to comply with 0.6 spec

Write a summary of the changes you are making
changes in:

  • beacon-chain/core/helpers/randao.go
  • beacon-chain/core/helpers/randao_test.go
  • shared/bytesutil/bytes.go

Link anything that would be helpful or relevant to the reviewers
https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#generate_seed

@terencechain terencechain changed the title update generateseed to 0.6 spec Update generateseed to 0.6 spec Apr 24, 2019
@shayzluf
Copy link
Contributor Author

added missing argument in active index function
fixed older problems in generate seed

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #2371 into spec-v0.6 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           spec-v0.6    #2371   +/-   ##
==========================================
  Coverage      65.37%   65.37%           
==========================================
  Files            121      121           
  Lines           9699     9699           
==========================================
  Hits            6341     6341           
  Misses          2660     2660           
  Partials         698      698

beacon-chain/core/helpers/randao.go Outdated Show resolved Hide resolved
beacon-chain/core/helpers/randao.go Outdated Show resolved Hide resolved
@shayzluf shayzluf force-pushed the update-generate_seed-v0.6 branch 2 times, most recently from 0f09a72 to 8f3dc56 Compare April 29, 2019 06:17
beacon-chain/core/helpers/randao.go Outdated Show resolved Hide resolved
beacon-chain/core/helpers/randao.go Outdated Show resolved Hide resolved
beacon-chain/core/helpers/randao.go Outdated Show resolved Hide resolved
@shayzluf shayzluf force-pushed the update-generate_seed-v0.6 branch from 8f3dc56 to 705bf37 Compare April 29, 2019 20:58
@shayzluf shayzluf merged commit 6a245ba into prysmaticlabs:spec-v0.6 Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants