Implement Epoch Processing Helpers - Attestations Matching #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 tasks
Codecov Report
@@ Coverage Diff @@
## spec-v0.6 #2379 +/- ##
=============================================
+ Coverage 66.45% 66.54% +0.08%
=============================================
Files 121 121
Lines 9599 9630 +31
=============================================
+ Hits 6379 6408 +29
Misses 2511 2511
- Partials 709 711 +2 |
terencechain
changed the title
0xKiwi
approved these changes
Apr 25, 2019
nisdas
approved these changes
Apr 26, 2019
| return nil, fmt.Errorf("could not get block root for epoch %d: %v", epoch, err) | ||
| } | ||
|
|
||
| var tgtAtts []*pb.PendingAttestation |
There was a problem hiding this comment.
can you set the size of the slices beforehand to reduce memory allocations
| return nil, fmt.Errorf("could not get block root for epoch %d: %v", epoch, err) | ||
| } | ||
|
|
||
| //var tgtAtts []*pb.PendingAttestation |
terencechain
added a commit
that referenced
this pull request
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2307
This PR implements the following epoch processing helpers and tests, the helpers are grouped into one logical processing function for efficiency reason (we don't have to loop through the attestations N^2 times)
get_matching_source_attestationsget_matching_target_attestationsget_matching_head_attestationsChanges:
BlockRootAtSlotandBlockRootTargetRootandHeadRootto bebyte, it wasuint64