Prevent Validator Exit Re-entance #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
Apr 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #2443 +/- ##
==========================================
+ Coverage 65.59% 65.65% +0.05%
==========================================
Files 122 122
Lines 9571 9570 -1
==========================================
+ Hits 6278 6283 +5
+ Misses 2585 2580 -5
+ Partials 708 707 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @shayzluf for pointing this out!
There's a bug on the old
ExitValidatorspec, where a validator can exit but re-exit again withinentryExitEffectEpochperiod. This prevents the bug by not letting validator exit again if the exit epoch is no longer setFarFutureEpochso the validator can only get exited/slashed/ejected once