Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Genesis with Trigger #2797

Closed
wants to merge 8 commits into from
Closed

Conversation

terencechain
Copy link
Member

This PR is part of #2307

It implements the is_genesis_trigger and use it in our eth1 chains service. The get_genesis_beacon_state is also updated to to latest version and to accommodate this change. This differs with the previous approach to using ChainStart event log to kick off beacon chain

@nisdas
Copy link
Member

nisdas commented Jun 14, 2019

@terencechain could you hold off on this until that change is merged into a release in the specs repo ?
Other things might end up changing till it is released

@terencechain
Copy link
Member Author

@nisdas right, and other changes that are not related to gensis should be part of different PR anyway

@stale
Copy link

stale bot commented Jun 24, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale There hasn't been any activity here in some time... label Jun 24, 2019
@terencechain
Copy link
Member Author

Closing for @shayzluf to pick up the rest

@terencechain terencechain deleted the is-genesis-trigger branch July 25, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale There hasn't been any activity here in some time...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants