Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Round Robin Test #3775

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Fix Round Robin Test #3775

merged 4 commits into from
Oct 15, 2019

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Oct 14, 2019

This fixes our test by fixing some bugs in our initial sync algorithm.

  • When choosing the count, we only need to take into account the original start value
  • If there is only 1 peer left, we should not continue dividing by the step value. As in situation with
    multiple failures, the step value grows large

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #3775 into master will increase coverage by 32.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3775       +/-   ##
===========================================
+ Coverage   26.53%   58.69%   +32.15%     
===========================================
  Files          42      176      +134     
  Lines        3267    11411     +8144     
===========================================
+ Hits          867     6698     +5831     
- Misses       2291     3816     +1525     
- Partials      109      897      +788

@nisdas nisdas merged commit 00a5a25 into master Oct 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixRoundRobinTest branch October 15, 2019 06:06
prestonvanloon added a commit that referenced this pull request Oct 22, 2019
nisdas pushed a commit that referenced this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants