Refactor validator roles into an array #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validator/client/validator.go
Outdated
| switch { | ||
| case assignment == nil: | ||
| role = pb.ValidatorRole_UNKNOWN | ||
| roles = append(roles, pb.ValidatorRole_UNKNOWN) | ||
| case assignment.ProposerSlot == slot && assignment.AttesterSlot == slot: |
There was a problem hiding this comment.
You can remove this case all together
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
Codecov Report
@@ Coverage Diff @@
## master #4081 +/- ##
==========================================
- Coverage 21.54% 16.49% -5.05%
==========================================
Files 167 82 -85
Lines 10899 4923 -5976
==========================================
- Hits 2348 812 -1536
+ Misses 8249 4007 -4242
+ Partials 302 104 -198 |
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
…iclabs/prysm into refactor-validator-roles
validator/client/validator.go
Outdated
| var roles []pb.ValidatorRole | ||
|
|
||
| if assignment == nil { | ||
| roles = append(roles, pb.ValidatorRole_UNKNOWN) |
There was a problem hiding this comment.
I think we can just leave it empty? No need to insert UNKNOWN when an empty roles array means no work to do
prestonvanloon
approved these changes
Nov 21, 2019
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have roles defined in PB as
attester,proposerandboth. This becomes not extensible as we introduce more roles. This PR refactors to validator client treat these roles as an array.Before:
pb.Both // attester and proposer both assigned to slot NAfter:
[]pb.Roles{pb.Attester, pb.Proposer} // attester and proposer both assigned to slot N