Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update P2P Service to Handle Local Metadata #5319

Merged
merged 21 commits into from
Apr 7, 2020
Merged

Update P2P Service to Handle Local Metadata #5319

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f90e0d9
add metadata to ENR
nisdas Apr 6, 2020
5bae2a6
Merge branch 'v0.11' of https://github.com/prysmaticlabs/geth-shardin…
nisdas Apr 7, 2020
9d976a6
add new methods
nisdas Apr 7, 2020
3126bc0
glue everything
nisdas Apr 7, 2020
97e948c
fix all tests and refs
nisdas Apr 7, 2020
8bb6ace
add tests
nisdas Apr 7, 2020
6662860
add more tests
nisdas Apr 7, 2020
99d685e
Apply suggestions from code review
nisdas Apr 7, 2020
976bb84
fix method
nisdas Apr 7, 2020
74ef0b8
raul's review
nisdas Apr 7, 2020
a76b766
gaz
rauljordan Apr 7, 2020
d64a72f
fix test setup
nisdas Apr 7, 2020
af5ad26
fix all tests
nisdas Apr 7, 2020
939c07b
Merge branch 'metaDataENR' of https://github.com/prysmaticlabs/geth-s…
nisdas Apr 7, 2020
e9a8b31
Merge refs/heads/v0.11 into metaDataENR
prylabs-bulldozer[bot] Apr 7, 2020
aed342a
better naming
rauljordan Apr 7, 2020
4f6d008
Merge branch 'metaDataENR' of github.com:prysmaticlabs/prysm into met…
rauljordan Apr 7, 2020
5194fea
fix broken test
rauljordan Apr 7, 2020
33352ba
Merge refs/heads/v0.11 into metaDataENR
prylabs-bulldozer[bot] Apr 7, 2020
e4d87e0
validate nil
rauljordan Apr 7, 2020
9981d73
Merge branch 'metaDataENR' of github.com:prysmaticlabs/prysm into met…
rauljordan Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions beacon-chain/sync/rpc_ping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ func (r *Service) validateSequenceNum(seq uint64, id peer.ID) (bool, error) {
if err != nil {
return false, err
}
if md == nil {
return false, nil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should actually return true then, we will need to request the peer's metadata in that case

}
if md.SeqNumber != seq {
return true, nil
}
Expand Down