Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert archival deprecations #5464

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Conversation

terencechain
Copy link
Member

We have just observed issues with new state management (#5462) and are not confident in this functionality enabled by default to launch Topaz. This PR brings back the archival deprecations so historical info are still accessible without --new-state-mgmt flag

@terencechain terencechain requested a review from a team as a code owner April 16, 2020 22:46
@terencechain terencechain self-assigned this Apr 16, 2020
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a clean revert of those PRs

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #5464 into master will decrease coverage by 11.18%.
The diff coverage is 59.92%.

@@             Coverage Diff             @@
##           master    #5464       +/-   ##
===========================================
- Coverage   53.54%   42.36%   -11.19%     
===========================================
  Files         306      266       -40     
  Lines       24960    22168     -2792     
===========================================
- Hits        13366     9392     -3974     
- Misses       9625    11091     +1466     
+ Partials     1969     1685      -284     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 62c25ea into master Apr 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert-archival-deprecations branch April 16, 2020 23:26
terencechain added a commit that referenced this pull request Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High High priority item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants