Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aggregation/attestations package #6343

Merged
merged 11 commits into from
Jun 23, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Jun 22, 2020

What type of PR is this?

Feature

What does this PR do? Why is it needed?

  • All code implementing the new aggregation attestation has been accumulated under aggregation and aggregation/attestation packages. Previous implementation aka naive aggregation code has also been moved here (w/o deleting it in original helpers/ directory).
  • The next PR (Enables new aggregation implementation #6344), will be solely to replace all the references to the previous implementation with the current one.
  • So, this PR is done to limit scope of changes:
    • It is safer to merge, as all changes are within aggregation/attestations and are not yet enabled
    • It is easier to review, as change is self-contained

Which issues(s) does this PR fix?

Other notes for review

@farazdagi farazdagi self-assigned this Jun 22, 2020
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rauljordan rauljordan merged commit 5c90038 into master Jun 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the aggregation-attestations-package branch June 23, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants