QSP-45 Add Check for No Connected Peers BestFinalized #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 tasks
nisdas
reviewed
Jun 25, 2020
nisdas
reviewed
Jun 26, 2020
nisdas
reviewed
Jun 26, 2020
nisdas
reviewed
Jun 26, 2020
nisdas
reviewed
Jun 26, 2020
There was a problem hiding this comment.
It would be good to have @farazdagi to also take a look at this, since this is mostly used in initial sync
farazdagi
suggested changes
Jun 26, 2020
There was a problem hiding this comment.
@nisdas thanks for summoning, I was going to work on the issue myself (I've marked my intent in #6327, Raul probably just didn't see my comment), so gladly adding my thoughts as a review:
I don't think that unless we re-write the method completely, we should do anything but:
- add a comment to
BestFinalized(), mentioning that client code must check the len(peers) before using extra info - review and make sure that current code does this (I suppose it does)
❗ Btw, have you noticed that we don't actually use the targetRoot anywhere (except tests), what we are using is epoch and peers. So, we can throw away the targetRoot and resolve QSP-45 that way.
rauljordan
force-pushed
the
best-finalized
branch
from
3dd7c08
to
ad92b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6327, we were not handling the case with 0 connected peers in the peer status BestFinalized() method. Instead, we were checking for no connected peers around the method but not in the method itself, which could lead to misuse down the line