QSP-33 Check Max Response For All Topics #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious what you think @nisdas |
61 tasks
…into max-response-chunks
|
@rauljordan looks good to me, but docker images need to be fixed. |
nisdas
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6327, we were not checking max response sizes for all p2p topics. We had two different funcs called
EncodeWithLengthandEncodeWithMaxLengthwhich both did the same thing, except the latter adds a check for the MaxChunkSize accordingly. Given every p2p gossip response is a chunk (even if a single chunk), we should be checking for this for all topics appropriately.