Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on block/attestation comments #6720

Merged
merged 4 commits into from
Jul 25, 2020
Merged

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Jul 25, 2020

Part of #6716

Update pseudocode comments to reflect the latest changes. There's nothing to change in the code

References:
ethereum/consensus-specs#1884
ethereum/consensus-specs#1880
ethereum/consensus-specs#1886

@terencechain terencechain added Ready For Review A pull request ready for code review v0.12.2 labels Jul 25, 2020
@terencechain terencechain requested a review from a team as a code owner July 25, 2020 00:23
@terencechain terencechain self-assigned this Jul 25, 2020
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prylabs-bulldozer prylabs-bulldozer bot merged commit 01f3a6e into master Jul 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the forkchoice-comments branch July 25, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants