Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet file lock #6952

Merged
merged 8 commits into from
Aug 10, 2020
Merged

Wallet file lock #6952

merged 8 commits into from
Aug 10, 2020

Conversation

shayzluf
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?
Try to acquire an exclusive lock on wallet file when running a validator in order to avoid two validators that are using the same wallet

Which issues(s) does this PR fix?

Part of #6948

Other notes for review

@shayzluf shayzluf requested a review from a team as a code owner August 10, 2020 15:16
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #6952 into master will decrease coverage by 0.44%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##           master    #6952      +/-   ##
==========================================
- Coverage   62.42%   61.98%   -0.45%     
==========================================
  Files         391      390       -1     
  Lines       31334    30545     -789     
==========================================
- Hits        19559    18932     -627     
+ Misses       9038     8937     -101     
+ Partials     2737     2676      -61     

@shayzluf shayzluf self-assigned this Aug 10, 2020
@rauljordan rauljordan merged commit 335d316 into master Aug 10, 2020
@farazdagi farazdagi deleted the wallet_file_lock branch August 11, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants