Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer scorer: fix weighted sorting #6981

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Peer scorer: fix weighted sorting #6981

merged 3 commits into from
Aug 13, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Fixing minor bug in peer scoring weighted sorting function, where weights in (0; 1) range weren't used correctly.
  • Additionally, updates default constants (so that delta in Peer scoring: init sync #6709 is lesser, and easier to review).

Which issues(s) does this PR fix?

Extracted from #6709

Other notes for review

@farazdagi farazdagi requested a review from nisdas August 12, 2020 22:46
@farazdagi farazdagi requested a review from a team as a code owner August 12, 2020 22:46
@farazdagi farazdagi self-assigned this Aug 12, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 0c94298 into master Aug 13, 2020
@farazdagi farazdagi deleted the minor-fixes-to-peer-scorer branch August 14, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@terencechain terencechain Awaiting requested review from terencechain

Assignees

@farazdagi farazdagi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farazdagi @nisdas