Update committee cache size to 32 #7018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
previously approved these changes
Aug 16, 2020
…s/prysm into update-committee-cache-size
prestonvanloon
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committee cache size is currently set to 10. This number assumed perfect finality (eg.
previous,currentandnextepoch with a few forks in between3 * fork_amount)In the event of no finality for a long time, this assumption quickly breaks and causes the running node to lock up more resources than needed due to shuffling.
A syncing node (before):
A syncing node (after):
From the UX perspective, the syncing felt smoother, and the computer didn't get too hot with the loud fan.
Some envelope numbers for the trade offs:
Each cache size is dependent on the number of active validator indices.
ShuffledIndicesandSortedIndicesare the only ones matter, the rest is too small to count. Each list is 30k * 64B = 2MB. This increases the memory usage by ~2MB * 22 = 44MB. It's a very acceptable trade off imo.