Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Retrieve From DB For Block Roots #7028

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Do Not Retrieve From DB For Block Roots #7028

merged 1 commit into from
Aug 17, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 17, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Hashes all blocks to get their block roots instead of using the db as this degrades during periods of non finality.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner August 17, 2020 08:10
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #7028 into master will decrease coverage by 0.10%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master    #7028      +/-   ##
==========================================
- Coverage   62.32%   62.21%   -0.11%     
==========================================
  Files         401      401              
  Lines       31368    31261     -107     
==========================================
- Hits        19549    19448     -101     
+ Misses       9057     9055       -2     
+ Partials     2762     2758       -4     

@prylabs-bulldozer prylabs-bulldozer bot merged commit f193dc2 into master Aug 17, 2020
@nisdas nisdas deleted the fixIssue branch August 17, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants