Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait interval, before finalized peers re-checked #7032

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other/Improvement

What does this PR do? Why is it needed?

  • Since there's no point in quickly spinning on existing peers, when no peers with high enough finalized slot is found, we add a period of 15s (configurable) before proceeding.
  • Number of errors tolerated are increased to 1000, so 1000*15 sec (~4 hours) of possible init-sync spinning is allowed by this update, then init-sync gives up.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@farazdagi farazdagi requested a review from nisdas August 17, 2020 12:13
@farazdagi farazdagi marked this pull request as ready for review August 17, 2020 12:30
@farazdagi farazdagi requested a review from a team as a code owner August 17, 2020 12:30
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #7032 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7032   +/-   ##
=======================================
  Coverage   62.54%   62.54%           
=======================================
  Files         401      401           
  Lines       31617    31617           
=======================================
  Hits        19775    19775           
  Misses       9059     9059           
  Partials     2783     2783           

@farazdagi farazdagi self-assigned this Aug 17, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit bde3073 into master Aug 17, 2020
@nisdas nisdas deleted the better-no-finalized-peers-handling branch August 17, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants