Reject Duplicate Blocks From Being Saved #7044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7044 +/- ##
==========================================
- Coverage 62.38% 62.17% -0.22%
==========================================
Files 401 401
Lines 31510 31389 -121
==========================================
- Hits 19657 19515 -142
- Misses 9081 9104 +23
+ Partials 2772 2770 -2 |
farazdagi
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In #7036 , we allow duplicate blocks to be inserted into the pending block cache. This PR fixes that and
makes sure duplicates are rejected.
Which issues(s) does this PR fix?
N.A
Other notes for review