Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves block deduplication on batch processing #7075

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Aug 21, 2020

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • On valid but forked blocks (in batches), we might get stuck in init-sync. In block-by-block processing this issue has been resolved by checking DB/cache for block's root (and only then deciding that block is duplicate). This PR applies that fix to batch processor as well.

Which issues(s) does this PR fix?

Fixes #6598

Other notes for review

  • This PR also fixes test (as we know updated 2nd stage, peers need to have not only finalized, but non-finalized blocks as queue will freely request beyond the finalized epoch). So, updated tests config a bit.

@farazdagi farazdagi requested a review from a team as a code owner August 21, 2020 10:14
@farazdagi farazdagi self-assigned this Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #7075 into master will decrease coverage by 0.26%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #7075      +/-   ##
==========================================
- Coverage   62.57%   62.30%   -0.27%     
==========================================
  Files         405      403       -2     
  Lines       31760    31485     -275     
==========================================
- Hits        19873    19616     -257     
+ Misses       9120     9090      -30     
- Partials     2767     2779      +12     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 05d6dc7 into master Aug 21, 2020
@farazdagi farazdagi deleted the last-processed-block-in-batch branch August 21, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial sync no good blocks in batch
2 participants