Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Validator Accounts V2 Send Deposit #7080

Merged
merged 21 commits into from
Aug 24, 2020
Merged

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Aug 21, 2020

What type of PR is this?

Feature

What does this PR do? Why is it needed?

This PR adds the ability to submit validator deposits via the accounts-v2 CLI for a Prysm HD wallet.

Usage

The user can submit the deposits interactively by following a nice prompt with a series of steps where they pick the accounts they want, confirm the amount of ETH being sent, and track the progress of the deposits. Alternatively, one can do the process non-interactively via CLI flags:

bazel run //validator -- accounts-v2 deposit \
    --wallet-dir=/Users/me/Library/Eth2Validators/prysm-wallet-v2 \
    --deposit-contract=0x8A3b401d1d3F33DDfDB03A3538A3EC9247ca089d \
    --eth1-private-key-file=/tmp/privkey.txt \
    --skip-deposit-confirmation \
    --http-web3provider=https://goerli.prylabs.network \
    --wallet-password-file=/tmp/walletpass.txt \
    --deposit-all-accounts

Will non-interactively send out deposits to the deposit contract! Deployed a dummy contract to goerli, so the command above should work for you.

@rauljordan rauljordan changed the title Create Validator Accounts V2 Create Validator Accounts V2 Send Deposit Aug 21, 2020
@rauljordan rauljordan marked this pull request as ready for review August 22, 2020 00:38
@rauljordan rauljordan requested a review from a team as a code owner August 22, 2020 00:38
@rauljordan rauljordan self-assigned this Aug 22, 2020
@rauljordan rauljordan added AccountsV2 Enhancement New feature or request labels Aug 22, 2020
terencechain
terencechain previously approved these changes Aug 22, 2020
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good me. I didnt test it though

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #7080 into master will increase coverage by 1.94%.
The diff coverage is 73.88%.

@@            Coverage Diff             @@
##           master    #7080      +/-   ##
==========================================
+ Coverage   60.07%   62.02%   +1.94%     
==========================================
  Files         323      408      +85     
  Lines       27422    31917    +4495     
==========================================
+ Hits        16473    19795    +3322     
- Misses       8733     9326     +593     
- Partials     2216     2796     +580     

Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
@prylabs-bulldozer prylabs-bulldozer bot merged commit c9c4cd9 into master Aug 24, 2020
@farazdagi farazdagi deleted the send-deposit branch August 25, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants