Unset From,Sequence Number and Signature For Pubsub Messages #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
approved these changes
Aug 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #7093 +/- ##
==========================================
+ Coverage 60.07% 62.31% +2.23%
==========================================
Files 323 406 +83
Lines 27422 31596 +4174
==========================================
+ Hits 16473 19688 +3215
- Misses 8733 9118 +385
- Partials 2216 2790 +574 |
|
@nisdas please wait with merging, you're ahead with the others. I'm not sure if Teku was up to date, they need to respond on the specs issue. The fields in gossip messages must not be left out yet. We're almost there, but not yet. |
|
Unblocking after confirming with Teku that they have already removed it on their end. @protolambda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Spec Change
What does this PR do? Why is it needed?
FromSeqnoSignaturefor pubsub messages in prysm.Which issues(s) does this PR fix?
Follows on from libp2p/go-libp2p-pubsub#359
and ethereum/consensus-specs#1981
Other notes for review