Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkpoint info cache #7098

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Use checkpoint info cache #7098

merged 4 commits into from
Aug 24, 2020

Conversation

terencechain
Copy link
Member

What type of PR is this?

Feature

What does this PR do? Why is it needed?

  • We hooked up sync service and core attestation service to use check point info cache to verify attestation signatures.
  • Due to this radical improvement, we reduce hot state cache size from 32 to 16. This reduces memory usages by 400-600MB
  • Use feature flag --use-check-point-cache

Which issues(s) does this PR fix?

Deprecates #7048

Other notes for review

Gated by feature flag and tested run time.

@terencechain terencechain added Enhancement New feature or request Ready For Review labels Aug 24, 2020
@terencechain terencechain requested a review from a team as a code owner August 24, 2020 17:49
@terencechain terencechain self-assigned this Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #7098 into master will increase coverage by 2.12%.
The diff coverage is 70.47%.

@@            Coverage Diff             @@
##           master    #7098      +/-   ##
==========================================
+ Coverage   60.07%   62.19%   +2.12%     
==========================================
  Files         323      406      +83     
  Lines       27422    31769    +4347     
==========================================
+ Hits        16473    19759    +3286     
- Misses       8733     9192     +459     
- Partials     2216     2818     +602     

@rauljordan rauljordan merged commit c764099 into master Aug 24, 2020
@rauljordan rauljordan deleted the use-cp-cache branch August 24, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants