Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Interop keys functional for accounts-v2, use v2 for E2E #7103

Merged
merged 7 commits into from
Aug 25, 2020

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Aug 24, 2020

What type of PR is this?
E2E Improvement

What does this PR do? Why is it needed?
This PR is part of #7101 , to help cover a hole in our test coverage.
Previously E2E was using accounts-v1, but since v2 is the default now, this should be changed.

@0xKiwi 0xKiwi requested a review from a team as a code owner August 24, 2020 22:06
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #7103 into master will increase coverage by 0.03%.
The diff coverage is 13.15%.

@@            Coverage Diff             @@
##           master    #7103      +/-   ##
==========================================
+ Coverage   61.75%   61.79%   +0.03%     
==========================================
  Files         408      408              
  Lines       32109    31829     -280     
==========================================
- Hits        19830    19668     -162     
+ Misses       9453     9364      -89     
+ Partials     2826     2797      -29     

@0xKiwi 0xKiwi linked an issue Aug 25, 2020 that may be closed by this pull request
@prylabs-bulldozer prylabs-bulldozer bot merged commit d8ea41c into master Aug 25, 2020
@0xKiwi 0xKiwi changed the title Make Interop keys functional for accounts-v2 Make Interop keys functional for accounts-v2, use v2 for E2E Aug 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the e2e-accounts-v2 branch August 25, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2e test to cover accounts v2
2 participants