Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Interop Mode #7106

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fix Interop Mode #7106

merged 1 commit into from
Aug 25, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 25, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Sets genesis time explicitly.

Which issues(s) does this PR fix?

Fixes #7014

Other notes for review

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7106 into master will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7106      +/-   ##
==========================================
- Coverage   61.85%   61.69%   -0.17%     
==========================================
  Files         408      408              
  Lines       32321    32059     -262     
==========================================
- Hits        19993    19779     -214     
+ Misses       9476     9457      -19     
+ Partials     2852     2823      -29     

Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nisdas nisdas merged commit 48fd40e into master Aug 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixInterop branch August 25, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interop mode does not use the interop genesis time
2 participants