Deprecate DisableNewStateMgmt Flag #7124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, one test is failing though @nisdas |
0xKiwi
previously approved these changes
Aug 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #7124 +/- ##
==========================================
- Coverage 62.35% 61.73% -0.62%
==========================================
Files 408 406 -2
Lines 33491 32135 -1356
==========================================
- Hits 20882 19839 -1043
+ Misses 9690 9481 -209
+ Partials 2919 2815 -104 |
farazdagi
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Flag Cleanup
What does this PR do? Why is it needed?
DisableNewStateMgmtflag as the new state managment is our defacto default and there is no wayto revert back to our old method of managing states.
Which issues(s) does this PR fix?
N.A
Other notes for review