Add previous epoch participation metrics #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 60.07% 61.65% +1.58%
==========================================
Files 323 406 +83
Lines 27422 32152 +4730
==========================================
+ Hits 16473 19823 +3350
- Misses 8733 9512 +779
- Partials 2216 2817 +601 |
|
A good follow up task is to use these metrics in e2e. cc @0xKiwi |
nisdas
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Adding these metrics as we found them useful in other clients.
The metrics tracking doc: https://hackmd.io/D5FmoeFZScim_squBFl8oA
Which issues(s) does this PR fix?
Fixes #
Other notes for review