Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Zero Root Requests #7151

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Handle Zero Root Requests #7151

merged 5 commits into from
Sep 1, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Sep 1, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Allows the rate limiter to accurately calculate requests with zero roots.
  • Adds unit test.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner September 1, 2020 12:39
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #7151 into master will increase coverage by 1.77%.
The diff coverage is 70.79%.

@@            Coverage Diff             @@
##           master    #7151      +/-   ##
==========================================
+ Coverage   60.07%   61.84%   +1.77%     
==========================================
  Files         323      408      +85     
  Lines       27422    32273    +4851     
==========================================
+ Hits        16473    19960    +3487     
- Misses       8733     9496     +763     
- Partials     2216     2817     +601     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 2349012 into master Sep 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the handleZeroRoots branch September 1, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants