Fixes timer resources leak in CountdownToGenesis #7175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
CountdownToGenesis()
:<-time.After()
was invoked on each loop iteration, and it is not GC'ed up until event fires (so, resources are accumulated as on each tick of the other ticker, loop progresses, and on a select - we generate anothertime.After
channel). What makes things even less optimized: we do not need thattime.After
case -- at all. This PR just checks on each iteration whether we can get out of the loop, w/o anytime.After
ticker := NewTicker()
is to callticker.Stop()
when ticker is done. This PR makes sure that both the original ticker (one that usesconfig.GenesisCountdownInterval
duration) and the more granular one are closed at the end of the function.prysm/shared/slotutil/countdown.go
Lines 37 to 40 in 0961fef
Which issues(s) does this PR fix?
N/A
Other notes for review
prysm/shared/slotutil/countdown.go
Lines 19 to 51 in 0961fef