Fix Health Reporting for Validator Client Node Connection #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Sep 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #7181 +/- ##
==========================================
+ Coverage 60.07% 61.59% +1.52%
==========================================
Files 323 410 +87
Lines 27422 32597 +5175
==========================================
+ Hits 16473 20079 +3606
- Misses 8733 9648 +915
- Partials 2216 2870 +654 |
0xKiwi
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node_connectionAPI endpoint was not working properly. We should return connected: false if there is any error either in the validator client status or in the retrieval of the node's sync status.