Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other/Refactoring/Minor fixing
What does this PR do? Why is it needed?
time.After
aggregated timer channels, and depending on the rate of incoming events it might be a problem (too many resources to garbage collect). I've changed routine to use explicittime.Timer.C
instead -- so at the moment only a single timer channel is open at a time. And when we need to reset (on every incoming event), previous timer is stopped, and new timer is created (which is exactly what happened when we usedtime.After()
with additional benefit of stopping the previous timer before creating a new one).Which issues(s) does this PR fix?
Other notes for review