Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Small Issue in Validator RPC Health Endpoint #7195

Merged
merged 7 commits into from
Sep 8, 2020
Merged

Fix Small Issue in Validator RPC Health Endpoint #7195

merged 7 commits into from
Sep 8, 2020

Conversation

rauljordan
Copy link
Contributor

This PR fixes a bad assumption from #7194, which should return connected: false if an error occurs in reaching sync status

@rauljordan rauljordan requested a review from a team as a code owner September 8, 2020 21:36
@rauljordan rauljordan self-assigned this Sep 8, 2020
@rauljordan rauljordan added API Api related tasks OK to merge labels Sep 8, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 6d83770 into master Sep 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-health-endpoint branch September 8, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKiwi 0xKiwi 0xKiwi approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@shayzluf shayzluf Awaiting requested review from shayzluf

@rkapka rkapka Awaiting requested review from rkapka

Assignees

@rauljordan rauljordan

Labels
API Api related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauljordan @0xKiwi