Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config PROPORTIONAL_SLASHING_MULTIPLIER #7275

Merged
merged 4 commits into from
Sep 19, 2020

Conversation

terencechain
Copy link
Member

Part of #7274 and aligning to spec v0.12.3

This PR added the proportional slashing multiplier config value and used it under process_final_update

Reference PR: ethereum/consensus-specs#2034

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #7275 into master will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7275      +/-   ##
==========================================
- Coverage   59.61%   59.38%   -0.24%     
==========================================
  Files         419      419              
  Lines       30157    29973     -184     
==========================================
- Hits        17978    17799     -179     
- Misses       9244     9259      +15     
+ Partials     2935     2915      -20     

rkapka
rkapka previously requested changes Sep 19, 2020
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo in the constant's name everywhere: Propotional (there is no r).

shared/params/config.go Outdated Show resolved Hide resolved
@terencechain terencechain dismissed rkapka’s stale review September 19, 2020 21:29

addressed, thanks!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 1f6afa8 into master Sep 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the prop-slashing-mul branch September 19, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants