Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Validator For Spadina #7314

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Fix Validator For Spadina #7314

merged 2 commits into from
Sep 23, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Sep 23, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Spadina was not declared anywhere for the validator v2 subcommands. This PR takes care of that.

Which issues(s) does this PR fix?

Other notes for review

@nisdas nisdas requested a review from a team as a code owner September 23, 2020 05:27
farazdagi
farazdagi reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

validator/accounts/v2/cmd_accounts.go Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit 49ae42c into master Sep 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the fixSpadina branch September 23, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farazdagi farazdagi farazdagi approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @farazdagi