Unnecessary Slice-to-Slice Conversion analyzer #7321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
changed the title
rauljordan
previously approved these changes
Sep 23, 2020
terencechain
requested changes
Sep 23, 2020
| @@ -0,0 +1,61 @@ | |||
| package slicedirect | |||
There was a problem hiding this comment.
Can you add an overall package level comment?
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
- Coverage 60.01% 59.89% -0.12%
==========================================
Files 416 416
Lines 29950 29857 -93
==========================================
- Hits 17975 17884 -91
- Misses 9035 9044 +9
+ Partials 2940 2929 -11 |
terencechain
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Tool
What does this PR do? Why is it needed?
This PR introduces a static code analyzer that reports a diagnostic when the
[:]is applied to an expression which is already of a slice type. Occurrences of such code in Prysm have been found here: https://deepsource.io/gh/rkapka/prysm/issue/CRT-A0016/occurrences/.Which issues(s) does this PR fix?
Part of #6747
Other notes for review
N/A