Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Compiler Flags for BLST #7352

Merged
merged 5 commits into from
Sep 26, 2020
Merged

Add New Compiler Flags for BLST #7352

merged 5 commits into from
Sep 26, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Sep 26, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Adds in the required C flags -D__BLST_PORTABLE__ and -O to prevent
    crashes in x86_64.
  • Fix Up Benchmarks.

Which issues(s) does this PR fix?

Part of #7312

Other notes for review

@nisdas nisdas marked this pull request as ready for review September 26, 2020 07:17
@nisdas nisdas requested a review from a team as a code owner September 26, 2020 07:17
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #7352 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7352      +/-   ##
==========================================
- Coverage   60.27%   60.08%   -0.20%     
==========================================
  Files         417      416       -1     
  Lines       30243    29951     -292     
==========================================
- Hits        18228    17995     -233     
+ Misses       9048     9017      -31     
+ Partials     2967     2939      -28     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 77c95f3 into master Sep 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the addNewOpts branch September 26, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants