Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional services flags #7358

Merged

Conversation

bidlocode
Copy link
Contributor

@bidlocode bidlocode commented Sep 27, 2020

Option to explicitly disable unneeded ports #7317

validator

  • added --rpc flag (now rpc-server and grpc-gateway disabled by default, enabled explicitly with --rpc or with --web)
  • added --disable-monitoring flag

slasher

  • added --disable-monitoring flag

@bidlocode bidlocode requested a review from a team as a code owner September 27, 2020 18:17
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #7358 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7358   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files         418      418           
  Lines       30313    30313           
=======================================
  Hits        18213    18213           
  Misses       9117     9117           
  Partials     2983     2983           

prestonvanloon
prestonvanloon previously approved these changes Sep 27, 2020
@prestonvanloon
Copy link
Member

@rauljordan can you take a look please?

@prylabs-bulldozer prylabs-bulldozer bot merged commit 558ee26 into prysmaticlabs:master Sep 30, 2020
@bidlocode bidlocode deleted the optional-services-flags branch September 30, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants