Fix Finalized Epoch Checks #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO(#5827) Verify the finalized block with the epoch in the | ||
| // status message | ||
| return nil | ||
| if helpers.SlotToEpoch(blk.Block.Slot) == msg.FinalizedEpoch { |
There was a problem hiding this comment.
Tests for these new chunk of code?
Codecov Report
@@ Coverage Diff @@
## master #7364 +/- ##
==========================================
- Coverage 60.20% 60.08% -0.13%
==========================================
Files 418 418
Lines 30067 30018 -49
==========================================
- Hits 18101 18035 -66
- Misses 9017 9036 +19
+ Partials 2949 2947 -2 |
Comment on lines
210
to
212
| if err != nil { | ||
| traceutil.AnnotateError(span, err) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| traceutil.AnnotateError(span, err) | |
| } | |
| traceutil.AnnotateError(span, err) |
AnnotateError is a no-op if err is nil, no need to check here
… into addBetterStatusChecks
terencechain
approved these changes
Sep 29, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
and finalized blocks and its relevant child blocks and verifying that their respective slots match up.
Which issues(s) does this PR fix?
Fixes #5827
Other notes for review